Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

thinkpad/x1-extreme/gen3: add module #1150

Merged
merged 1 commit into from
Sep 29, 2024

Conversation

CyberShadow
Copy link
Contributor

@CyberShadow CyberShadow commented Sep 28, 2024

Description of changes

Add module for Lenovo Thinkpad X1 Extreme (Gen 3).

Gen 2 and Gen 4 were already there.

One thing that was new compared to either is a kernel parameter for the psmouse module which fixes clicking with the clickpad. The solution is described here: https://discourse.nixos.org/t/touchpad-click-not-working/12276

Things done
  • Tested the changes in your own NixOS Configuration
  • Tested the changes end-to-end by using your fork of nixos-hardware and
    importing it via <nixos-hardware> or Flake input

@CyberShadow CyberShadow marked this pull request as ready for review September 28, 2024 16:44
@Mic92
Copy link
Member

Mic92 commented Sep 29, 2024

Please also add this to the README and flake.nix

@CyberShadow
Copy link
Contributor Author

Done

@Mic92
Copy link
Member

Mic92 commented Sep 29, 2024

@mergify queue

Copy link
Contributor

mergify bot commented Sep 29, 2024

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 9fe0e21

mergify bot added a commit that referenced this pull request Sep 29, 2024
@mergify mergify bot merged commit 9fe0e21 into NixOS:master Sep 29, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants