Microchip uboot build failure with nixpkgs 23.05 #661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix for NixOS/nixpkgs#235179 Update Microchip uboot version to linux4microchip+fpga-2023.06 Signed-off-by: Ganga Ram <[email protected]>
|
These changes are backward compatible i.e. works fine with nixpkgs 22.11 |
|
Please review. |
|
Just undraft when you are done and I will have a look again. |
Added branch name, for better trackability. Co-authored-by: Sandro <[email protected]>
|
bors merge |
bors bot
added a commit
that referenced
this pull request
Jul 11, 2023
661: Microchip uboot build failure with nixpkgs 23.05 r=Mic92 a=codehub8 Co-authored-by: Ganga Ram <[email protected]> Co-authored-by: Ganga Ram <[email protected]>
|
This PR was included in a batch that successfully built, but then failed to merge into master (it was a non-fast-forward update). It will be automatically retried. |
|
Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
|
Thank you :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for NixOS/nixpkgs#235179
Update Microchip uboot version to linux4microchip+fpga-2023.06
Description of changes
Patch for Microchip uboot, which fixes build issue against binutils 2.38
From version 2.38, binutils default to ISA spec version 20191213. This
means that the csr read/write (csrr*/csrw*) instructions and fence.i
instruction has separated from the
Iextension, become two standaloneextensions: Zicsr and Zifencei. As the kernel uses those instruction,
this causes build failure.
Things done
nixos-hardwareandimporting it via
<nixos-hardware>or Flake input