Add formatting team #1337
Merged
Add formatting team #1337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15 tasks
|
Could you please add my full name - Sergey Gulin? |
infinisil
force-pushed
the
formatting-team
branch
from
6656009 to
25ef4d6
Compare
|
Thank you! |
|
Also noticed that |
mweinelt
reviewed
Mar 14, 2024
src/content/teams/12_formatting.mdx
Outdated
| github: tomberek | ||
| title: | ||
| - name: Joachim Ernst | ||
| github: 0x4A6F |
There was a problem hiding this comment.
Suggested change
| github: 0x4A6F | |
| github: "0x4A6F" |
infinisil
force-pushed
the
formatting-team
branch
from
25ef4d6 to
79e7892
Compare
infinisil
force-pushed
the
formatting-team
branch
from
79e7892 to
b95dc6f
Compare
0x4A6F
approved these changes
Mar 14, 2024
dasJ
approved these changes
Mar 14, 2024
thilobillerbeck
approved these changes
Mar 14, 2024
|
@piegamesde @tomberek Please also review |
mweinelt
reviewed
Mar 14, 2024
| members: | ||
| - name: Silvan Mosberger | ||
| github: infinisil | ||
| title: Administrative leader, sponsored by Tweag and Antithesis |
There was a problem hiding this comment.
Is there a precedent for such a sponsorship remark?
There was a problem hiding this comment.
Me and @fricklerhandwerk also have that for the docs team, as does @ConnorBaker from the cuda team, all from Tweag
tomberek
reviewed
Mar 19, 2024
tomberek
force-pushed
the
formatting-team
branch
from
b95dc6f to
538cc93
Compare
tomberek
approved these changes
Mar 19, 2024
piegamesde
approved these changes
Mar 19, 2024
Sereja313
reviewed
Mar 19, 2024
As established by RFC 166 https://github.com/NixOS/rfcs/blob/master/rfcs/0166-nix-formatting.md#nix-formatter-team Co-authored-by: tomberek <[email protected]> Co-authored-by: Sereja313 <[email protected]>
infinisil
force-pushed
the
formatting-team
branch
from
ae26a32 to
58d15e0
Compare
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/formatting-team-meeting-2024-03-19/41845/1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As established by RFC 166, see also NixOS/nixfmt#153.
Before merging I'd like all members to give their okay with their entry. Ping @NixOS/nix-formatting