Small buttons update #1608
Open
Small buttons update #1608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
SvMak
commented
Dec 14, 2024
SvMak
commented
- use cva(class-variance-authority) for variants;
- made all buttons full rounded.
thilobillerbeck
requested changes
Dec 24, 2024
| import Link from '@/components/util/Link.astro'; | ||
|
|
||
| export const buttonVariants = cva( | ||
| 'font-bold text-white drop-shadow transition-colors rounded-full text-center', |
There was a problem hiding this comment.
Fully rounded corners are an interesting design change, though I'm not really a fan of it, this comes especially into play when seeing how buttons behave inside cards as seen on the learn site. The fully rounded corners do not really seem to fit into the more boxy card shape, while the old design aligns more with its parent design and at least in my opinion looks more coherent.
Comment on lines
+12
to
+15
| orange: 'bg-nix-orange hover:bg-nix-orange-hover', | ||
| lightblue: 'bg-nix-blue-light hover:bg-nix-blue-light-hover', | ||
| semidarkblue: 'bg-nix-blue-dark hover:bg-nix-blue-dark-hover', | ||
| green: 'bg-nix-green hover:bg-nix-green-hover', |
There was a problem hiding this comment.
In my testing I couldn't really tell how the hover state applied, am I missing something or is it just to subtile? I'd guess the mentioned colors may need to be defined first. :D
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.