Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

top-level/packages-config.nix: Correctly index package subsets delimited by dots #113680

Closed

Conversation

adisbladis
Copy link
Member

Motivation for this change

Fixes the issue discovered by @Atemu in #110348 (comment) where dot delimited subsets were not taken into account.

Note: I haven't tested how this interacts with search at all, I've just assumed it's probably fine. This needs more testing to see what the implications are, hence I've marked it as draft.

cc @garbas

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@adisbladis adisbladis force-pushed the packages-config-dotted-sets branch from 4ab4190 to 4060a6d Compare February 19, 2021 12:01
@ofborg ofborg bot requested a review from Mic92 February 19, 2021 12:04
@adisbladis adisbladis removed the request for review from Mic92 February 19, 2021 12:05
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux and removed 10.rebuild-darwin: 1 10.rebuild-darwin: 1-10 10.rebuild-linux: 1 10.rebuild-linux: 1-10 labels Feb 19, 2021
@Atemu
Copy link
Member

Atemu commented Feb 19, 2021

I haven't tested how this interacts with search at all

Search have their OOT version of this file to generate the search index; that's where I copied it from actually ;)

Copy link
Member

@Atemu Atemu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aborts with infinite recursion for me.

Also needs a bit of formatting cleanup and/or refactoring I think ;)

@adisbladis
Copy link
Member Author

Closing this one as I think #113713 is clearly better.

@adisbladis adisbladis closed this Feb 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants