Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

arduino: 1.8.13 -> 1.8.16 #144634

Merged
merged 2 commits into from
Nov 4, 2021
Merged

arduino: 1.8.13 -> 1.8.16 #144634

merged 2 commits into from
Nov 4, 2021

Conversation

Stunkymonkey
Copy link
Contributor

@Stunkymonkey Stunkymonkey commented Nov 4, 2021 •
edited
Loading

Motivation for this change

update

ZHF: #144627
fixing arduino & arduino-core on aarch64

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from bjornfor and bergey November 4, 2021 17:15
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 labels Nov 4, 2021
@Stunkymonkey Stunkymonkey force-pushed the arduino-1.8.16 branch 2 times, most recently from 44f801a to 5a41178 Compare November 4, 2021 17:45
@Stunkymonkey Stunkymonkey changed the title arduino: 1.8.16 -> 1.8.16 arduino: 1.8.13 -> 1.8.16 Nov 4, 2021
@mattmelling
Copy link
Contributor

Result of nixpkgs-review pr 144634 run on x86_64-linux 1

1 package failed to build:
  • teensyduino
4 packages built:
  • arduino
  • arduino-core
  • ino
  • octavePackages.arduino

@Stunkymonkey
Copy link
Contributor Author

i will fix teensyduino. give me a sec.

@SuperSandro2000 SuperSandro2000 merged commit bae0cf0 into NixOS:master Nov 4, 2021
@Stunkymonkey Stunkymonkey deleted the arduino-1.8.16 branch December 5, 2021 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattmelling mattmelling mattmelling approved these changes

@bjornfor bjornfor Awaiting requested review from bjornfor

@bergey bergey Awaiting requested review from bergey

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Stunkymonkey @mattmelling @SuperSandro2000