Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[21.05] tonelib-jam: init at 4.7.0 && tonelib-zoom init at 4.3.1 && tonelib-gfx init at 4.7.0 #144643

Closed

Conversation

dan4ik605743
Copy link
Member

@dan4ik605743 dan4ik605743 commented Nov 4, 2021

Motivation for this change
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@dan4ik605743 dan4ik605743 changed the title tonelib-jam: 4.6.6 -> 4.7.0 tonelib-jam: init at 4.7.0 Nov 4, 2021
@dan4ik605743 dan4ik605743 changed the title tonelib-jam: init at 4.7.0 [21.05] tonelib-jam: init at 4.7.0 Nov 4, 2021
@dan4ik605743 dan4ik605743 changed the title [21.05] tonelib-jam: init at 4.7.0 [21.05] tonelib-jam: init at 4.7.0 && tonelib-zoom init at 4.3.1 && tonelib-gfx init at 4.7.0 Nov 4, 2021
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 10.rebuild-linux: 1 and removed 10.rebuild-linux: 1 labels Nov 4, 2021
@jonringer
Copy link
Contributor

When backporting changes, please follow https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md#backporting-changes.

Namely, you should be doing git cherry-pick -x <rev> from a commit that has already landed in master. If the branches have diverged, you may alter the commit or add another commit to ensure that the package is able to still evaluate and build

@dan4ik605743
Copy link
Member Author

I know how the backporting is being done, but it's not that having happened, I don't even have these packages in this Branch, in general, from the word completely, even old versions, so it is not backporting, but the first release is here.

When backporting changes, please follow https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md#backporting-changes.

Namely, you should be doing git cherry-pick -x <rev> from a commit that has already landed in master. If the branches have diverged, you may alter the commit or add another commit to ensure that the package is able to still evaluate and build

@dan4ik605743
Copy link
Member Author

I even don't even have a sheet here in Maintainer, I'm not push anything here.

Copy link
Member Author

@dan4ik605743 dan4ik605743 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Packages are completely in good condition.
image

@jonringer
Copy link
Contributor

Each commit should be referencing the commit which landed in master

Namely, you should be doing git cherry-pick -x from a commit that has already landed in master. If the branches have diverged, you may alter the commit or add another commit to ensure that the package is able to still evaluate and build

@dan4ik605743
Copy link
Member Author

Each commit should be referencing the commit which landed in master

Namely, you should be doing git cherry-pick -x from a commit that has already landed in master. If the branches have diverged, you may alter the commit or add another commit to ensure that the package is able to still evaluate and build

ok

@dan4ik605743 dan4ik605743 deleted the backport-tonelib_jam branch December 1, 2021 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants