Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

thefuck: fix build on darwin #144651

Merged
merged 1 commit into from
Nov 4, 2021
Merged

Conversation

malob
Copy link
Member

@malob malob commented Nov 4, 2021

Motivation for this change

thefuck isn't currently building on Darwin systems due to some tests failing. This PR disables the relevant tests.

I could imagine that it's possible to change the derivation in some way to enable those tests to run successfully, but I don't know enough to do that myself.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

ZHF: #144627
cc: @NixOS/nixos-release-managers

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Nov 4, 2021
@ofborg ofborg bot requested a review from SuperSandro2000 November 4, 2021 20:21
@SuperSandro2000 SuperSandro2000 merged commit cd45372 into NixOS:master Nov 4, 2021
@malob malob deleted the fix-thefuck-darwin branch November 5, 2021 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants