Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.pydicom: add missing setuptools runtime dependency #147930

Merged
merged 1 commit into from
Nov 29, 2021

Conversation

bcdarwin
Copy link
Member

Motivation for this change

Missing dependency, not previously detected due to #133032.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • [NA] (Package updates) Added a release notes entry if the change is major or breaking
    • [NA] (Module updates) Added a release notes entry if the change is significant
    • [NA] (Module addition) Added a release notes entry if adding a new NixOS module
    • [NA] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@fabaff
Copy link
Member

fabaff commented Nov 29, 2021

Result of nixpkgs-review pr 147930 run on x86_64-linux 1

4 packages marked as broken and skipped:
  • python38Packages.nipype
  • python38Packages.pybids
  • python39Packages.nipype
  • python39Packages.pybids
2 packages failed to build:
  • python38Packages.nilearn
  • python39Packages.nilearn
17 packages built:
  • expliot
  • intensity-normalization (python39Packages.intensity-normalization)
  • python38Packages.dicom2nifti
  • python38Packages.dipy
  • python38Packages.intensity-normalization
  • python38Packages.nibabel
  • python38Packages.nipy
  • python38Packages.nitime
  • python38Packages.pydicom
  • python38Packages.pynetdicom
  • python39Packages.dicom2nifti
  • python39Packages.dipy
  • python39Packages.nibabel
  • python39Packages.nipy
  • python39Packages.nitime
  • python39Packages.pydicom
  • python39Packages.pynetdicom

Copy link
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. nilearn failure is not new.

@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 labels Nov 29, 2021
@fabaff
Copy link
Member

fabaff commented Nov 29, 2021

nilearn failure will be addressed with #147936

@fabaff fabaff merged commit ee3e468 into NixOS:master Nov 29, 2021
@bcdarwin bcdarwin deleted the pydicom-setuptools-dep branch November 29, 2021 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants