nixos/seafile: add optional seafdav service

[Pacman99]

Motivation for this change

add webdav support for seafile

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 22.05 Release Notes (or backporting 21.11 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
  • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
• Fits CONTRIBUTING.md.

Configuration Example

{
  services.seafile.seafdavSettings = {
    enabled = true;
    share_name = "/seafdav";
  };
  services.nginx.virtualHosts."files.example.com" = {
    locations."/seafdav".proxyPass = "http://127.0.0.1:6001/seafdav";
  };
}

[Tungsten842]

Result of nixpkgs-review pr 152069 run on x86_64-linux 1

2 packages blacklisted:

• nixos-install-tools
• tests.nixos-functions.nixos-test

2 packages built:

• python38Packages.seafdav (python39Packages.seafdav)
• python38Packages.seafobj (python39Packages.seafobj)

[greizgh]

Thank you for contributing this feature, I'll test and report back.

[dotlambda]

seafdav shouldn't be in pythonPackages, so put it in all-packages.nix and move the expression to an appropriate directory

[Pacman99]

Thanks! I addressed most of the code review and fixed the commit messages.

[Pacman99]

I'm going to mark as draft until #153388 is merged

[Pacman99]

Thank you for the review! I applied everything and rebased.

[dotlambda]

The last commit message should start with nixos/seafile.

[dotlambda]

Maybe this should be changed since you didn't actually package version 7.0.0.

[Pacman99]

I guess I packaged the pre-release of the next version, but then I'd have to predict what the next version number for seafobj would be.

[Pacman99]

Filed an issue upstream for adding setuptools support: haiwen/seafobj#57

[dotlambda]

@Pacman99 Is this done? You should sqash the last commit into the appropriate one and as said above, the third commit message should start with nixos/seafile.

[Pacman99]

@Pacman99 Is this done? You should sqash the last commit into the appropriate one and as said above, the third commit message should start with nixos/seafile.

I think so, I think I can deal with the setuptools issue in the future, hopefully with an upstream fix. And I believe I've addressed all your review, let me know if I'm missing anything else.

[shimunn]

What's blocking this, any help needed?