Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

furnace: init at 0.5.6 #158229

Merged
merged 1 commit into from
Feb 19, 2022
Merged

furnace: init at 0.5.6 #158229

merged 1 commit into from
Feb 19, 2022

Conversation

OPNA2608
Copy link
Contributor

@OPNA2608 OPNA2608 commented Feb 5, 2022

Motivation for this change

https://github.com/tildearrow/furnace, a very new, FOSS & actively developed alternative to the closed-source music tracker DefleMask.

(#81815, ping @fgaz)

We need to use the vendored SDL2 because the minimum supported version is 2.0.18, which we don't have packaged (#154137).

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@OPNA2608 OPNA2608 changed the title furnace: init at 0.5.3 furnace: init at 0.5.4 Feb 5, 2022
fgaz
fgaz approved these changes Feb 7, 2022
View reviewed changes
Copy link
Member

@fgaz fgaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good and the program runs smoothly.

And wow, this project is awesome! Mixing different chips like it's nothing

@fgaz fgaz mentioned this pull request Feb 7, 2022
Open
86 tasks
@OPNA2608 OPNA2608 changed the title furnace: init at 0.5.4 furnace: init at 0.5.5 Feb 10, 2022
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/440

@OPNA2608 OPNA2608 marked this pull request as draft February 10, 2022 11:19
@OPNA2608
Copy link
Contributor Author

OPNA2608 commented Feb 10, 2022 •
edited
Loading

The latest version introduced some ObjC code which breaks the Darwin build. I have yet to figure out a working fix for this 😦.

Bildschirmfoto von 2022-02-10 12-20-29

Edit: I found a fix & submitted a PR, waiting for upstream's response.

SuperSandro2000
SuperSandro2000 reviewed Feb 11, 2022
View reviewed changes
pkgs/applications/audio/furnace/default.nix Outdated Show resolved Hide resolved
pkgs/applications/audio/furnace/default.nix Outdated Show resolved Hide resolved
pkgs/applications/audio/furnace/default.nix Show resolved Hide resolved
pkgs/applications/audio/furnace/default.nix Outdated Show resolved Hide resolved
@OPNA2608 OPNA2608 changed the base branch from master to staging February 18, 2022 18:56
@OPNA2608 OPNA2608 changed the title furnace: init at 0.5.5 furnace: init at 0.5.6 Feb 18, 2022
@OPNA2608 OPNA2608 marked this pull request as ready for review February 18, 2022 18:57
@OPNA2608
Copy link
Contributor Author

OPNA2608 commented Feb 18, 2022 •
edited
Loading

Bumped to new 0.5.6 release. Spent the entire last day building a version of this merged onto staging on x86_64-linux & -darwin just to test.

@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Feb 18, 2022 •
edited
Loading

@ofborg build furnace

@SuperSandro2000 SuperSandro2000 merged commit afe8d59 into NixOS:staging Feb 19, 2022
@OPNA2608 OPNA2608 deleted the init/furnace branch September 27, 2022 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@fgaz fgaz fgaz approved these changes

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@OPNA2608 @nixos-discourse @SuperSandro2000 @fgaz