tiatracker: init at 1.3

[fgaz]

Motivation for this change

#81815 cc @OPNA2608

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 22.05 Release Notes (or backporting 21.11 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
  • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
• Fits CONTRIBUTING.md.

[OPNA2608]

Code looks okay. Build passes & binary works on Linux, but fails on Darwin.

Looks like the QMake script was never tested on Darwin. I haven't tested it locally but try this:

postPatch = ''
  substituteInPlace TIATracker.pro \
    --replace 'linux:' 'unix:'
'';

If that doesn't fix the build on CI I'll look into it on my machine.

---

As a note, do you know about this fork? Haven't tested it myself but it seems like it has some nice additions.

[fgaz]

As a note, do you know about this fork? Haven't tested it myself but it seems like it has some nice additions.

Ooh that's nice! Do you think we should package that instead, or do both?

[OPNA2608]

Fixed all the Darwin stuff in fgaz#3, builds & works on my machine now.

Do you think we should package that instead, or do both?

I would be in favour of doing both just cuz "why not?". But I don't have much experience with using trackers or the TIA so I can't judge how crucial these changes are (except undo/redo, which is obviously an improvement).

[fgaz]

I would be in favour of doing both just cuz "why not?"

That's pretty much in the spirit of nixpkgs, and I agree :D
I'll add it to the list

[nixos-discourse]

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/471

[SuperSandro2000]

Suggested change

	inherit (src.meta) homepage;
	homepage = "https://bitbucket.org/kylearan/tiatracker";

[SuperSandro2000]

Suggested change

	inherit description;
	description = "Music tracker for making Atari VCS 2600 music";

[SuperSandro2000]

Suggested change

	desktopItems = lib.optionals stdenv.hostPlatform.isLinux [ desktopItem ];
	desktopItems = [
	(makeDesktopItem {
	name = "TIATracker";
	desktopName = "TIATracker";
	comment = meta.description;
	exec = "TIATracker";
	icon = "tiatracker";
	type = "Application";
	categories = "AudioVideo;AudioVideoEditing;";
	extraEntries = "Keywords=tracker;music;";
	})
	];

[SuperSandro2000]

Suggested change

	let
	description = "Music tracker for making Atari VCS 2600 music";
	desktopItem = makeDesktopItem {
	name = "TIATracker";
	desktopName = "TIATracker";
	comment = description;
	exec = "TIATracker";
	icon = "tiatracker";
	type = "Application";
	categories = "AudioVideo;AudioVideoEditing;";
	extraEntries = "Keywords=tracker;music;";
	};
	in mkDerivation rec {
	mkDerivation rec {