Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

munin: switch to python3 #165184

Merged
merged 1 commit into from
Mar 23, 2022
Merged

munin: switch to python3 #165184

merged 1 commit into from
Mar 23, 2022

Conversation

armeenm
Copy link
Contributor

@armeenm armeenm commented Mar 21, 2022

Description of changes

#148779
Upstream has had Python 3 support for quite some time: munin-monitoring/munin@3809849, munin-monitoring/munin@43bf78e, ...

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from bjornfor March 21, 2022 22:45
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Mar 21, 2022
@WolfangAukang
Copy link
Contributor

Result of nixpkgs-review pr 165184 run on x86_64-linux 1

1 package built:
  • munin

@mweinelt
Copy link
Member

@ofborg test munin

@SuperSandro2000 SuperSandro2000 merged commit 1a53950 into NixOS:master Mar 23, 2022
@armeenm armeenm deleted the munin-python3 branch March 23, 2022 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants