Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump pocketsphinx/sphinxbase #169609

Closed
wants to merge 2 commits into from
Closed

Conversation

armeenm
Copy link
Contributor

@armeenm armeenm commented Apr 21, 2022

Description of changes

Pocketsphinx was last updated >5 years ago in nixpkgs. Though upstream has yet to put out a tagged release, this update should rid us of more Python 2 dependencies (#148779).

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@Mindavi
Copy link
Contributor

Mindavi commented Apr 24, 2022

Result of nixpkgs-review pr 169609 run on x86_64-linux 1

3 packages built:
  • parlatype
  • pocketsphinx
  • sphinxbase

@Mindavi
Copy link
Contributor

Mindavi commented Apr 24, 2022

I wouldn't be opposed to removing it altogether. Only parlatype seems to depend on this, and parlatype is unmaintained in nixpkgs as well (the only bumps I've seen are from r-ryantm and the original submitter @melchips never left any review comments on bumps). (Parlatype is still working though, I tested it with this PR)

There's also a haskell package (cut-the-crap) depending on this, but it's marked broken...

So I think it may be better to remove these packages.

@armeenm
Copy link
Contributor Author

armeenm commented Apr 24, 2022

Made a PR to remove everything. #170124

@armeenm armeenm closed this Apr 24, 2022
@armeenm armeenm deleted the bump-pocketsphinx branch April 24, 2022 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants