Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ntdb: remove #169639

Merged
merged 1 commit into from
Apr 23, 2022
Merged

ntdb: remove #169639

merged 1 commit into from
Apr 23, 2022

Conversation

armeenm
Copy link
Contributor

@armeenm armeenm commented Apr 21, 2022

Description of changes

ntdb is no longer used by samba and was last updated 8+ years ago. It also depends on python2 (#148779).

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 8.has: clean-up 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Apr 21, 2022
@Artturin
Copy link
Member

It hasn't been abandoned by upstream, scroll down and you'll see they've made a release this year
So the throw should be changed

This hasn't been updated in nixpkgs in many years so I think it's safe to assume no one is using this

@armeenm
Copy link
Contributor Author

armeenm commented Apr 23, 2022

That is tdb, not ntdb. ntdb only has one release on that page at the top.

@Artturin
Copy link
Member

Ah

@Artturin Artturin merged commit f4d6274 into NixOS:master Apr 23, 2022
@armeenm armeenm deleted the remove-ntdb branch April 23, 2022 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: clean-up 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants