Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

supercollider: fix build with libsndfile >=1.1.0 #172208

Merged
merged 1 commit into from
May 10, 2022
Merged

supercollider: fix build with libsndfile >=1.1.0 #172208

merged 1 commit into from
May 10, 2022

Conversation

lilyinstarlight
Copy link
Member

@lilyinstarlight lilyinstarlight commented May 9, 2022 •
edited
Loading

Description of changes

Add patch from supercollider/supercollider#5761 to fix supercollider build with the libsndfile update in #166374

ZHF: #172160

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.
nixpkgs-review

Result of nixpkgs-review run on x86_64-linux 1

8 packages built:
  • foxdot (python39Packages.foxdot)
  • python310Packages.foxdot
  • sonic-pi
  • supercollider
  • supercollider-with-plugins
  • supercollider-with-sc3-plugins
  • supercolliderPlugins.sc3-plugins
  • supercollider_scel

@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels May 9, 2022
@lilyinstarlight lilyinstarlight added the 0.kind: build failure A package fails to build label May 9, 2022
@lilyinstarlight
Copy link
Member Author

lilyinstarlight commented May 9, 2022 •
edited
Loading

I guess this should be a part of ZHF, since it is currently failing in Hydra (https://hydra.nixos.org/build/176203591)
@NixOS/nixos-release-managers

Jiehong
Jiehong approved these changes May 9, 2022
View reviewed changes
Copy link
Contributor

@Jiehong Jiehong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@WolfangAukang
Copy link
Contributor

WolfangAukang commented May 9, 2022 •
edited
Loading

Result of nixpkgs-review pr 172208 run on x86_64-linux 1

8 packages built:
  • foxdot (python39Packages.foxdot)
  • python310Packages.foxdot
  • sonic-pi
  • supercollider
  • supercollider-with-plugins
  • supercollider-with-sc3-plugins
  • supercolliderPlugins.sc3-plugins
  • supercollider_scel

FoxDot executes fine

@Artturin Artturin merged commit 892dff6 into NixOS:master May 10, 2022
@lilyinstarlight lilyinstarlight deleted the fix/supercollider-with-libsndfile-1.1.0 branch May 10, 2022 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WolfangAukang WolfangAukang WolfangAukang approved these changes

@Jiehong Jiehong Jiehong approved these changes

Assignees
No one assigned
Labels
0.kind: build failure A package fails to build 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lilyinstarlight @WolfangAukang @Jiehong @Artturin