Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pprof: unstable-2021-09-30 -> unstable-2022-05-09 #172251

Merged
merged 1 commit into from
May 10, 2022

Conversation

trofi
Copy link
Contributor

@trofi trofi commented May 9, 2022

Fixed build failure against binutils-2.28.
ZHF: #172160

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

Fixed build failure against binutils-2.28.
@WolfangAukang
Copy link
Contributor

WolfangAukang commented May 9, 2022

Result of nixpkgs-review pr 172251 run on x86_64-linux 1

1 package built:
  • pprof

Running the --help flag worked fine

@WolfangAukang WolfangAukang added the 0.kind: build failure A package fails to build label May 9, 2022
Copy link
Contributor

@WolfangAukang WolfangAukang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The best approach would be someone that uses pprof to approve the changes, but as there are no maintainers, no dependencies according to nixpkgs-review and this PR currently fixes the build, then I approve it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants