-
-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix sile wrapper issues on darwin. #172407
Conversation
I didn't see a maintainers list for the lua interpreters package so if there is someone else I should be cc-ing on this let me know. I'm not sure if it's worth having this be conditionally used on darwin as opposed to all platforms but that would also be an option. |
I have tested on a darwin M1 macbook and it seems to work. I have not tested on linux or x86 platforms. |
This cannot be considered complete yet but it appears to work for
|
Hello!
|
Darwin execve has issues with shebang lines that point to other scripts with shebang lines. A new makeBinaryWrapper hook was added to workaround the issue on darwin. See NixOS#171473 and NixOS#23018 for more information. This uses that binary wrapper to fix packages like sile. I'm not sure this can be considered complete but it appears to work for sile at least.
I closed and reopened a different one to target staging at: #172749 |
Darwin execve has issues with shebang lines that point to other scripts
with shebang lines. A new makeBinaryWrapper hook was added to workaround
the issue on darwin. See #171473 and #23018 for more information. This
uses that binary wrapper to fix packages like sile.
cc: @doronbehar, alerque
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)nixos/doc/manual/md-to-db.sh
to update generated release notes