Revert "cln: fix build on darwin"

[risicle]

Reverts #172921

Self quoting here...

Propose we revert this because it doesn't actually fix the problem and breaks darwin x86_64. This approach produces an empty output because it can't find any Makefile because autoconf/automake hasn't been run on the source. I'm also not sure what difference pulling the source from git would make.

Interestingly, the author has made several commits to master in the last few days related to ARM assembly, so it's possible some combination of those applied as patches might help things. Could also look to see if there were a way to disable ARM assembly, because reading the commit messages it looks rather like a work in progress.

ZHF: #172160

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 22.05 Release Notes (or backporting 21.11 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
  • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
• Fits CONTRIBUTING.md.

[siraben]

@risicle thanks for the PR. Please remember to make the branch on your fork rather than the nixpkgs repo

[github-actions]

Successfully created backport PR #175049 for release-22.05.

[risicle]

I think that's just because I used the "revert" button on the previous PR.

[siraben]

Hm. This breaks aarch64-darwin again, specifically transitive packages such as cvc4.

[risicle]

But that can only be because with the previous situation those reverse-dependencies were clearly happy being fed an "empty" cln. This suggests that they're actually optional dependencies and perhaps the packages should be updated to not require cln.

[risicle]

Literally, the cln package output was an empty directory for both darwin-aarch64 and darwin-x86_64

[siraben]

Right. I can confirm. Ok then the dependency should be removed since cvc4 still works without cln.