Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.typer: disable completion tests on all platforms #175034

Closed

Conversation

risicle
Copy link
Contributor

@risicle risicle commented May 27, 2022

Description of changes

These were previously just failing on aarch64 but #174995 started to show them failing on x86_64 linux. It's possible this shellingham library just doesn't like doing its thing inside the nix build environment.

ZHF: #172160

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@risicle risicle added the 0.kind: build failure A package fails to build label May 27, 2022
@risicle risicle marked this pull request as ready for review May 27, 2022 23:16
@risicle risicle requested review from FRidh and jonringer as code owners May 27, 2022 23:16
@ofborg ofborg bot requested a review from winpat May 27, 2022 23:21
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 11-100 labels May 27, 2022
@risicle risicle force-pushed the ris-typer-disable-completion-tests branch from 1a26c1f to 6df1f4b Compare May 30, 2022 21:31
@pbsds
Copy link
Member

pbsds commented Aug 6, 2022

This PR fails to evaluate once merged on top of master:

error: undefined variable 'stdenv'

       at /home/pbsds/.cache/nixpkgs-review/pr-175034/nixpkgs/pkgs/development/python-modules/typer/default.nix:53:23:

           52|     "test_install_completion"
           53|   ] ++ lib.optionals (stdenv.isLinux && stdenv.isAarch64) [
             |                       ^
           54|     "test_install_completion"

Please rebase it

@risicle
Copy link
Contributor Author

risicle commented Aug 6, 2022

I think I'll close it instead as it would appear most people aren't having this problem (anymore?)

@risicle risicle closed this Aug 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.kind: build failure A package fails to build 6.topic: python 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 11-100
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants