Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.cnvkit: 0.9.7 -> 0.9.9, skip broken test #175357

Merged
merged 1 commit into from
May 29, 2022

Conversation

risicle
Copy link
Contributor

@risicle risicle commented May 29, 2022

Description of changes

Bring this one back from the brink.

Skipped test looks like it's broken upstream with pysam 0.18.0 and joblib restriction looks like it's outdated.

ZHF: #172160

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@risicle risicle marked this pull request as ready for review May 29, 2022 20:55
@risicle risicle requested review from FRidh and jonringer as code owners May 29, 2022 20:55
@ofborg ofborg bot requested a review from jbedo May 29, 2022 21:02
Copy link
Contributor

@jbedo jbedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested build & functionality, LGTM.

@jbedo jbedo merged commit fda1a42 into NixOS:master May 29, 2022
};

patches = [
# Fix: AttributeError: module 'pandas.io.common' has no attribute 'EmptyDataError'
(fetchpatch {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the unused fetchpatch from inputs.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MB, shouldn't have missed that.

@github-actions
Copy link
Contributor

Successfully created backport PR #175373 for release-22.05.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants