Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport release-22.05] libnatspec: fix build on darwin #175529

Merged
merged 2 commits into from
May 30, 2022
Merged

[Backport release-22.05] libnatspec: fix build on darwin #175529

merged 2 commits into from
May 30, 2022

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented May 30, 2022 •
edited by risicle
Loading

Bot-based backport to release-22.05, triggered by a label in #175127.

  • Before merging, ensure that this backport complies with the Criteria for Backporting.
    • Even as a non-commiter, if you find that it does not comply, leave a comment.

risicle added 2 commits May 30, 2022 21:52
@risicle @github-actions
libnatspec: fix build on darwin
27fbb13 
broken in 3c12e95 when parentheses
were removed, changing the semantics.

add libiconv universally to avoid such mixups.

(cherry picked from commit 8e11324)
@risicle @github-actions
libnatspec: unmark broken on darwin
cc7b00b 
(cherry picked from commit 0120216)
@github-actions github-actions bot mentioned this pull request May 30, 2022
Merged
13 tasks
@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label May 30, 2022
risicle
risicle approved these changes May 30, 2022
View reviewed changes
Copy link
Contributor

@risicle risicle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nixpkgs-review happy, macos x86_64

@risicle risicle merged commit 9895371 into release-22.05 May 30, 2022
@risicle risicle deleted the backport-175127-to-release-22.05 branch May 30, 2022 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@risicle risicle risicle approved these changes

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@risicle