-
-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[staging-next] python3Packages.protobuf: fix drv version #194111
Conversation
846ce88
to
582361a
Compare
Any update? |
My PC seems not capable of handling some large python packges. They require too much memory. 😢 |
582361a
to
9e01549
Compare
I tried running nixpkgs-review on this pull request, but I am also running out of memory (16GB seems not enough).
Logs
Logs
|
I met some other dependency requirement failure. 🤔 Maybe it's better to keep both python libs instead? |
Result of 214 packages marked as broken and skipped:
33 packages failed to build:
281 packages built:
|
9e01549
to
49cfef7
Compare
I give up pinning it back to 3.20. Now I did the reverse: just correct version to 4.21 and fix build failure of dependent packages by unrestrict the protobuf requirement. This should be fine according to #194112 (comment) |
Most of failures left are either,
Result of 226 packages marked as broken and skipped:
12 packages failed to build:
302 packages built:
|
f121b1d
to
8bd4d92
Compare
Rebased and removed fixes that already included in |
Result of /!\ I believe the OOM killer killed something in nixpkgs-review. I set 58 packages marked as broken and skipped:
52 packages failed to build:
396 packages built:
|
@erdnaxe Thanks for the test. I think we should fix them individually in |
TL;DR: Currently the
python3Packages.protobuf.version
is 3.21 but its output is actually 4.21, which cause suspicious breakages. This PR targetsstaging-next
for the fix.EDIT: I give up pinning it back to 3.20. Now I did the reverse: just correct version to 4.21
and fix build failure of dependent packages by unrestrict the protobuf requirement. This should be fine according to #194112 (comment)OLD ATTEMPT:
protobuf 3.21 coresponds with its python library 4.21, which diverges and causes many breakages. protobuf 3.20 is also the last version having the same version as its python library.
See: https://developers.google.com/protocol-buffers/docs/news/2022-05-06#python-updates
Fixes #193997 and tested
electrum
.Note that this will also break some packages requiring
protobuf >= 4
, likebiliass
. But using 4 breakstouch
(pytorch/pytorch#78362),electrum
(spesmilo/electrum#7833),keepkey
(keepkey/python-keepkey#146) and any packages containing a legacy generated_pb2.py
.I think pinning to 3.20 would cause less harm.
I'm still running nixpkgs-review to see how it goes.
Description of changes
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)nixos/doc/manual/md-to-db.sh
to update generated release notes