vikunja-desktop: init at 0.24.3

[kolaente]

Description of changes

This PR adds the desktop version of Vikunja. Since it is only an electron wrapper around the frontend and the frontend is already packaged in nixos, this package reuses that.

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 22.11 Release Notes (or backporting 22.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
  • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
• Fits CONTRIBUTING.md.

[kolaente]

Not sure about my change to the release notes, never done that before.

[mweinelt]

The package is not referenced by any top-leve attribute.

[mweinelt]

{"error":"invalid_request","error_description":"The request is missing a required parameter, includes an invalid parameter value, includes a parameter more than once, or is otherwise malformed. The 'redirect_uri' parameter does not match any of the OAuth 2.0 Client's pre-registered redirect urls."}

The app recognized my instance was using SSO to login, but once I click that button I get this error.

Tried both https://example.com as well as https://example.com/api/v1.

[kolaente]

What frontend version is that? You should be able to see that by opening the dev console in the electron shell.

[mweinelt]

The deployment still uses 0.19.1.

Vikunja frontend version 0.19.1

The redirect url is way off.

https://accounts.darmstadt.ccc.de/api/oidc/authorization?client_id=vikunja&redirect_uri=http://127.0.0.1:45735/auth/openid/sso&response_type=code&scope=openid%20email%20profile&state=whrvtu3tmwj

[kolaente]

The deployment still uses 0.19.1.

Let's wait until the frontend update got merged, that should fix the problem.

The redirect url is way off.

I'm afraid there's no way around that. The desktop app spins up a local server to serve frontend files, a redirect back from the provider has to happen there.

[mweinelt]

Please rebase and squash the commits.

[kolaente]

Took me a little longer than I'd like to admit but it should all be correctly rebased now.

[kolaente]

@mweinelt I'm not sure what I need to change so that ofborg works.

[kolaente]

Rebased and updated. The package compiles and starts successfully, but then fails with this error when running it:

App threw an error during load
Error: Cannot find module 'body-parser'
Require stack:
- /nix/store/y18anvcdqk1qk406v0m93i74gpva6f1l-vikunja-desktop-0.24.3/share/lib/vikunja-desktop/resources/app.asar/node_modules/express/lib/express.js
- /nix/store/y18anvcdqk1qk406v0m93i74gpva6f1l-vikunja-desktop-0.24.3/share/lib/vikunja-desktop/resources/app.asar/node_modules/express/index.js
- /nix/store/y18anvcdqk1qk406v0m93i74gpva6f1l-vikunja-desktop-0.24.3/share/lib/vikunja-desktop/resources/app.asar/main.js
    at Module._resolveFilename (node:internal/modules/cjs/loader:1152:15)
    at s._resolveFilename (node:electron/js2c/browser_init:2:121381)
    at Module._load (node:internal/modules/cjs/loader:993:27)
    at c._load (node:electron/js2c/node_init:2:17025)
    at Module.require (node:internal/modules/cjs/loader:1240:19)
    at require (node:internal/modules/helpers:179:18)
    at Object.<anonymous> (/nix/store/y18anvcdqk1qk406v0m93i74gpva6f1l-vikunja-desktop-0.24.3/share/lib/vikunja-desktop/resources/app.asar/node_modules/express/lib/express.js:15:18)
    at Module._compile (node:internal/modules/cjs/loader:1373:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1432:10)
    at Module.load (node:internal/modules/cjs/loader:1215:32)

I have absolutely no idea why it does this. The packages compiled by upstream work fine, so this does not seem to be a problem of dependency declaration here.

After having spent a few hours on this without anything really to show for, I wonder if it would be easier to fetch the built package by upstream and patch it?

[mweinelt]

Will defer to @lilyinstarlight and @winterqt

[maralorn]

I would love to see progress on this, but I have little to no clue about the problem.