Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hipcub: init at 2.12.0-5.3.1 #197342

Closed
wants to merge 2 commits into from
Closed

hipcub: init at 2.12.0-5.3.1 #197342

wants to merge 2 commits into from

Conversation

Madouura
Copy link
Contributor

@Madouura Madouura commented Oct 23, 2022 •
edited
Loading

Description of changes

Tracking: #197885
Second part in a whole bunch of porting...
hipcub.passthru.tests will likely always fail due to it being in a vm, but I have confirmed the tests generated do work on hardware.
Depends on #197838
Depends on #197337

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@Madouura Madouura requested a review from lovesegfault October 23, 2022 08:17
@github-actions github-actions bot added the 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS label Oct 23, 2022
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Oct 23, 2022
@Madouura
Copy link
Contributor Author

Whoops, forgot to turn tests/benchmarks off by default.

@Madouura
Copy link
Contributor Author

Cleaned up some things.

@Madouura Madouura force-pushed the pr/hipcub branch 2 times, most recently from 47d28b5 to 6b73b60 Compare October 26, 2022 07:07
@Madouura
Copy link
Contributor Author

Now depends on #197838

@Madouura Madouura mentioned this pull request Oct 26, 2022
Open
34 tasks
@Madouura Madouura force-pushed the pr/hipcub branch 2 times, most recently from 4821342 to cd4e9a4 Compare October 30, 2022 17:09
@Madouura Madouura changed the title hipcub: init at 2.12.0-5.3.0 hipcub: init at 2.12.0-5.3.1 Oct 30, 2022
@Madouura
Copy link
Contributor Author

Madouura commented Nov 4, 2022

Rolled into #198770

@Madouura Madouura closed this Nov 4, 2022
@Madouura Madouura deleted the pr/hipcub branch November 4, 2022 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lovesegfault lovesegfault lovesegfault left review comments

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Madouura @lovesegfault