Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rocsparse: init at 2.3.2-5.3.1 #197455

Closed
wants to merge 2 commits into from
Closed

Conversation

Madouura
Copy link
Contributor

@Madouura Madouura commented Oct 23, 2022

Description of changes

Tracking: #197885
Third part in a whole bunch of porting...
rocsparse.passthru.tests will likely always fail due to it being in a vm, but I have confirmed a subset of tests (there are like 284K of them...) generated do work on hardware all tests work!.
We may want to consider how many of these tests we want to do whenever it is possible to use GPU acceleration (emulated or real) in testing vms.
Depends on #197337

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS label Oct 23, 2022
@Madouura Madouura requested a review from lovesegfault October 23, 2022 23:50
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Oct 23, 2022
@Madouura
Copy link
Contributor Author

Cleaned up some things.

@Madouura
Copy link
Contributor Author

Changed some overly-verbose paths.

@Madouura Madouura force-pushed the pr/rocsparse branch 2 times, most recently from a8f0b5c to fd40737 Compare October 24, 2022 15:50
@Madouura Madouura mentioned this pull request Oct 26, 2022
34 tasks
@Madouura Madouura force-pushed the pr/rocsparse branch 2 times, most recently from a2cb8bf to 462e36d Compare October 27, 2022 18:51
@Madouura
Copy link
Contributor Author

Before not all tests were passing after I ran it longer because ${rocsparse.test} was missing the generated matrices directory. That is fixed now.

[----------] Global test environment tear-down
[==========] 282847 tests from 328 test suites ran. (9524521 ms total)
[  PASSED  ] 282847 tests.

@Madouura Madouura changed the title rocsparse: init at 2.3.2-5.3.0 rocsparse: init at 2.3.2-5.3.1 Oct 30, 2022
@Madouura
Copy link
Contributor Author

Madouura commented Nov 4, 2022

Rolled into #198770

@Madouura Madouura closed this Nov 4, 2022
@Madouura Madouura deleted the pr/rocsparse branch November 4, 2022 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants