Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rocthrust: init at 2.16.0-5.3.1 #197705

Closed
wants to merge 1 commit into from
Closed

rocthrust: init at 2.16.0-5.3.1 #197705

wants to merge 1 commit into from

Conversation

Madouura
Copy link
Contributor

@Madouura Madouura commented Oct 25, 2022 •
edited
Loading

Description of changes

Tracking: #197885
Seventh part in a whole bunch of porting...
No nixosTests for this one for now.
Tests and benchmarks are completely borked with no clear fix or if it's even a packaging issue. They're commented out for use later when this is fixed here or upstream.
Depends on #197337

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@Madouura Madouura requested a review from lovesegfault October 25, 2022 10:06
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Oct 25, 2022
@Madouura Madouura mentioned this pull request Oct 26, 2022
Open
34 tasks
@Madouura
Copy link
Contributor Author

Related: ROCm/rocThrust#258

@Madouura Madouura changed the title rocthrust: init at 2.16.0-5.3.0 rocthrust: init at 2.16.0-5.3.1 Oct 30, 2022
@lovesegfault
Copy link
Member

Please roll-up all your PRs into a single one since I've already reviewed them, get rid of the NixOS tests that always fail, and then I can merge that.

Otherwise you're going to have to rebase after each merge

@Madouura
Copy link
Contributor Author

Madouura commented Nov 4, 2022

Rolled into #198770

@Madouura Madouura closed this Nov 4, 2022
@Madouura Madouura deleted the pr/rocthrust branch November 4, 2022 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lovesegfault lovesegfault lovesegfault left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Madouura @lovesegfault