Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tensile: init at 4.34.0-5.3.1 #197719

Closed
wants to merge 1 commit into from
Closed

tensile: init at 4.34.0-5.3.1 #197719

wants to merge 1 commit into from

Conversation

Madouura
Copy link
Contributor

@Madouura Madouura commented Oct 25, 2022 •
edited
Loading

Description of changes

Tracking: #197885
Eighth part in a whole bunch of porting...
Mainly for incoming rocBLAS (have mercy on my PC...)

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@azahi
Copy link
Member

azahi commented Oct 25, 2022

Result of nixpkgs-review pr 197719 run on x86_64-linux 1

1 package built:
  • tensile

@Madouura Madouura mentioned this pull request Oct 26, 2022
Open
34 tasks
@Madouura
Copy link
Contributor Author

Madouura commented Oct 30, 2022 •
edited
Loading

After further investigation, particularly using rocBLAS, I am fairly certain this can be merged as-is.
However, Tensile can use rocminfo, rocm-smi, and hip at runtime.
I am torn on whether I want to include these as propogatedBuildInputs, so if anyone thinks I should or should not, please let me know.
In the meantime, marking this as ready on the tracker.

@Madouura
Copy link
Contributor Author

IIRC from the source, llvm_rocm (clang and a couple other tools specifically) as well.

@Madouura Madouura changed the title tensile: init at 4.34.0-5.3.0 tensile: init at 4.34.0-5.3.1 Oct 30, 2022
@Madouura Madouura requested a review from lovesegfault November 3, 2022 12:18
@lovesegfault
Copy link
Member

Needs a rebase

@Madouura
Copy link
Contributor Author

Madouura commented Nov 4, 2022

Rolled into #198770

@Madouura Madouura closed this Nov 4, 2022
@Madouura Madouura deleted the pr/tensile branch November 4, 2022 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lovesegfault lovesegfault lovesegfault left review comments

@azahi azahi azahi approved these changes

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Madouura @azahi @lovesegfault