Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

darwin.builder: Temporarily disable build #207776

Closed
wants to merge 1 commit into from
Closed

darwin.builder: Temporarily disable build #207776

wants to merge 1 commit into from

Conversation

Gabriella439
Copy link
Contributor

… until we can figure out why it's being rebuilt for seemingly unrelated changes.

See: #206951 (comment)

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@Gabriella439
darwin.builder: Temporarily disable build
8b9dc6d 
… until we can figure out why it's being rebuilt for seemingly
unrelated changes.

See: NixOS#206951 (comment)
@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Dec 26, 2022
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Dec 26, 2022
@Gabriella439 Gabriella439 mentioned this pull request Dec 26, 2022
Merged
13 tasks
@ofborg ofborg bot added 8.has: clean-up 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 labels Dec 26, 2022
roberth
roberth requested changes Dec 26, 2022
View reviewed changes
Copy link
Member

@roberth roberth left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A similar problem exists for nixos-install-tools.

I think we need someone to run nix-diff on the old and new derivation. (Thanks for writing that tool btw!)

I don't think we should remove this.

@Gabriella439
Copy link
Contributor Author

Where is the existing logic for detecting differences like these?

@roberth
Copy link
Member

roberth commented Dec 27, 2022

That'd be somewhere in https://github.com/NixOS/ofborg. I'm not familiar with that code base.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roberth roberth roberth requested changes

@domenkozar domenkozar Awaiting requested review from domenkozar

@zowoq zowoq Awaiting requested review from zowoq

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: clean-up 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Gabriella439 @roberth