-
-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mongodb: 3.2.9 -> 3.4.1 #22050
mongodb: 3.2.9 -> 3.4.1 #22050
Conversation
@@ -43,21 +43,15 @@ in stdenv.mkDerivation rec { | |||
name = "mongodb-${version}"; | |||
|
|||
src = fetchurl { | |||
url = "http://downloads.mongodb.org/src/mongodb-src-r${version}.tar.gz"; | |||
sha256 = "06q6j2bjy31pjwqws53wdpmn2x8w2hafzsnv1s3wx15pc9vq3y15"; | |||
url = "https://fastdl.mongodb.org/src/mongodb-src-r${version}.tar.gz"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Domain changed to fastdl
because that's what I found on the MongoDB website.
# tcmalloc - so we need to lift the include path manipulation out of the | ||
# conditional. | ||
./valgrind-include.patch | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Patch removed because it is included in the source.
This version segfaults on darwin https://gist.github.com/LnL7/07a14189e4fa059d56e33210f239d686 |
I'm still getting the segfault on darwin after the update. I suggest forking the package in two where mongodb_3_2 is the default and mongodb_3_4 the new one that only works on linux. |
Maybe https://github.com/Homebrew/homebrew-core/blob/master/Formula/mongodb.rb will give us some hints like the requirement on cxx11 |
@zimbatm @LnL7 @copumpkin can we test this on darwin again and see if it still segfaults? |
This might have been fixed by #27598, I don't remember if I tested this afterwards. |
Merged just now when mongodb needs another patch due to a |
Nice, I was about to submit https://github.com/NixOS/nixpkgs/compare/master...pbogdan:mongodb-fix-build?expand=1 but didn't realise an upstream patch was available. |
Motivation for this change
The desire to use MondoDB's
$replaceRoot
aggregation operator.Things done
(nix.useSandbox on NixOS,
or option
build-use-sandbox
innix.conf
on non-NixOS)
nix-shell -p nox --run "nox-review wip"
./result/bin/
)