Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

buildGoModule: Fix overriding with overlay-style stdenv #225051

Merged
merged 2 commits into from
Aug 16, 2024

Commits on Jul 28, 2024

  1. buildGoModule: respect user-specified passthru

    Prioritize user-specified passthru arguments over those added by
    buildGoModule.
    ShamrockLee committed Jul 28, 2024
    Configuration menu
    Copy the full SHA
    010277d View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2024

  1. buildGoModule: fix overrideAttrs overriding

    Fix overriding of vendorHash and various attributes via the fixed point
    attribute support of stdenv.mkDerivation.
    
    Pass as derivation attributes
    goModules, modRoot, vendorHash, deleteVendor, and proxyVendor.
    
    Move goModules and vendorHash out of passthru.
    
    Co-authored-by: Doron Behar <[email protected]>
    ShamrockLee and doronbehar committed Aug 11, 2024
    Configuration menu
    Copy the full SHA
    eed069a View commit details
    Browse the repository at this point in the history