racket: disable on darwin #23612
Closed
racket: disable on darwin #23612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@henrytill, thanks for your PR! By analyzing the history of the files in this pull request, we identified @gridaphobe, @aske and @letac to be potential reviewers. |
|
I personally prefer not to change the platforms for packages that should work. |
|
This should be fixed by #22571. |
A much better solution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Darwin builds of Racket are segfaulting for unknown reasons:
https://hydra.nixos.org/build/49778947
I don't have the capacity to troubleshoot this issue ATM. Anyone with the capacity is more than welcome to try to fix the build, but until such a person steps forward, I am proposing that we simply disable builds on Darwin.
Aside from updating the
meta.platformsattribute, I have kept other bits of Darwin-specific code intact so that they will not be lost to the sands of time.Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)