mcontrolcenter: init at 0.4.1 #251816
Closed
mcontrolcenter: init at 0.4.1 #251816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MControlCenter provides a relatively full-featured control panel for MSI laptops, written in Qt. It allows users to control MSI laptop power plans, fan speed, battery charging limits, keyboard backlight settings, USB power sharing and more. The application comes with strong desktop integration: shortcuts, taskbar item, etc. etc. -- screenshots here: https://github.com/dmitry-s93/MControlCenter/blob/main/README.md This package has been previous requested by the NixOS community: NixOS#244881 The package comes with a patch that corrects MControlCenter's path to the `modprobe` binary, allowing it to automatically load the `ec_sys` kernel module (included with NixOS by default) with the right settings when launched. This NixOS package has been fully tested on a NixOS Plasma5 desktop.
FliegendeWurst
suggested changes
Nov 9, 2023
|
|
||
| meta = with lib; { | ||
| homepage = "https://github.com/dmitry-s93/MControlCenter"; | ||
| description = "An application that allows you to change the settings of MSI laptops running Linux."; |
There was a problem hiding this comment.
Suggested change
| description = "An application that allows you to change the settings of MSI laptops running Linux."; | |
| description = "Tool to change the settings of MSI laptops running Linux"; |
| meta = with lib; { | ||
| homepage = "https://github.com/dmitry-s93/MControlCenter"; | ||
| description = "An application that allows you to change the settings of MSI laptops running Linux."; | ||
| licencse = licenses.gpl3; |
There was a problem hiding this comment.
Suggested change
| licencse = licenses.gpl3; | |
| licencse = licenses.gpl3Plus; |
https://github.com/dmitry-s93/MControlCenter/blob/main/src/main.cpp#L8
| "-DENABLE_INSTALL=ON" | ||
| ]; | ||
|
|
||
| installPhase = '' |
There was a problem hiding this comment.
Suggested change
| installPhase = '' | |
| installPhase = '' | |
| runHook preInstall |
| echo "Name=mcontrolcenter.helper" >> $out/share/dbus-1/system-services/mcontrolcenter.helper.service | ||
| echo "Exec=$out/libexec/mcontrolcenter-helper" >> $out/share/dbus-1/system-services/mcontrolcenter.helper.service | ||
| echo "User=root" >> $out/share/dbus-1/system-services/mcontrolcenter.helper.service | ||
| ''; |
There was a problem hiding this comment.
Suggested change
| ''; | |
| runHook postInstall | |
| ''; |
| ]; | ||
|
|
||
| buildInputs = [ | ||
| pkgs.cmake |
There was a problem hiding this comment.
Suggested change
| pkgs.cmake |
| ]; | ||
|
|
||
| nativeBuildInputs = [ | ||
| wrapQtAppsHook |
There was a problem hiding this comment.
Suggested change
| wrapQtAppsHook | |
| cmake | |
| wrapQtAppsHook |
| @@ -0,0 +1,62 @@ | |||
| { pkgs, lib, stdenv, qtbase, wrapQtAppsHook, qttools, makeDesktopItem, copyDesktopItems, fetchFromGitHub }: | |||
There was a problem hiding this comment.
Suggested change
| { pkgs, lib, stdenv, qtbase, wrapQtAppsHook, qttools, makeDesktopItem, copyDesktopItems, fetchFromGitHub }: | |
| { pkgs, lib, stdenv, qtbase, wrapQtAppsHook, qttools, makeDesktopItem, copyDesktopItems, fetchFromGitHub, cmake }: |
| @@ -0,0 +1,62 @@ | |||
| { pkgs, lib, stdenv, qtbase, wrapQtAppsHook, qttools, makeDesktopItem, copyDesktopItems, fetchFromGitHub }: | |||
|
|
|||
| stdenv.mkDerivation (finalAttrs: rec { | |||
There was a problem hiding this comment.
Suggested change
| stdenv.mkDerivation (finalAttrs: rec { | |
| stdenv.mkDerivation (finalAttrs: { |
| @@ -0,0 +1,2 @@ | |||
| { pkgs ? import <nixpkgs> {} }: | |||
| pkgs.libsForQt5.callPackage ./derivation.nix {} | |||
There was a problem hiding this comment.
Usually, this line would be in pkgs/top-level/all-packages.nix.
Also please don't try to import <nixpkgs> in nixpkgs.
wegank
added
2.status: stale
13 tasks
|
I would consider closing this pull request. I contacted personally the author and he is not interested in completing it any more, he also encouraged me to take over the work if I have a need for this package. I think is better to move the effort to #306216 and try to get this package merged. |
stale
bot
removed
the
2.status: stale
|
#306216 has just been merged, mcontrolcenter is now into master, there is no need for this pull request any more, please can we close it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MControlCenter provides a relatively full-featured control panel for MSI laptops, written in Qt. It allows users to control MSI laptop power plans, fan speed, battery charging limits, keyboard backlight settings, USB power sharing and more.
The application comes with strong desktop integration: shortcuts, taskbar item, etc. etc. -- screenshots here:
https://github.com/dmitry-s93/MControlCenter/blob/main/README.md
This package has been previous requested by the NixOS community: #244881
The package comes with a patch that corrects MControlCenter's path to the
modprobebinary, allowing it to automatically load theec_syskernel module (included with NixOS by default) with the right settings when launched.This NixOS package has been fully tested on a NixOS Plasma5 desktop.
Description of changes
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)