Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nebula: 1.7.2 -> 1.8.0 #272581

Merged
merged 1 commit into from
Dec 11, 2023
Merged

nebula: 1.7.2 -> 1.8.0 #272581

merged 1 commit into from
Dec 11, 2023

Conversation

nh2
Copy link
Contributor

@nh2 nh2 commented Dec 7, 2023

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
      • No breaking changes in the upstream changelog
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@nh2
Copy link
Contributor Author

nh2 commented Dec 7, 2023

TODO

The NixOS VM test currently fails for me, but does so equally before this commit, on nixos-unstable:

allowFromLighthouse: must succeed: ping -c5 10.0.100.3
allowFromLighthouse # ping: connect: Network is unreachable
allowFromLighthouse: output: 
cleanup
kill machine (pid 60)

Maybe there is a race?

it worked on ofborg in https://github.com/NixOS/nixpkgs/pull/236006/checks?check_run_id=13997210471

@nh2
Copy link
Contributor Author

nh2 commented Dec 7, 2023

CC maintainers @Br1ght0ne @numinit

@numinit
Copy link
Contributor

numinit commented Dec 10, 2023

Looked at the NixOS tests, they should be fixed by #273273.

@numinit
Copy link
Contributor

numinit commented Dec 10, 2023

Should we support this too (in another PR)?

slackhq/nebula#929

Bet this would have fixed the test flakiness too.

@numinit
Copy link
Contributor

numinit commented Dec 10, 2023

@nh2 Test flakiness fix is merged. Once we merge this we'll do another PR for the systemd ready socket.

@numinit
Copy link
Contributor

numinit commented Dec 10, 2023

cc @Jaculabilis (one of the original authors of the NixOS module)

@wegank wegank merged commit cdf0763 into NixOS:master Dec 11, 2023
28 checks passed
numinit pushed a commit to numinit/nixpkgs that referenced this pull request Dec 14, 2023
numinit pushed a commit to numinit/nixpkgs that referenced this pull request Dec 14, 2023
numinit pushed a commit to numinit/nixpkgs that referenced this pull request Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants