-
-
Notifications
You must be signed in to change notification settings - Fork 13.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nebula: 1.7.2 -> 1.8.0 #272581
nebula: 1.7.2 -> 1.8.0 #272581
Conversation
TODOThe NixOS VM test currently fails for me, but does so equally before this commit, on
Maybe there is a race? it worked on ofborg in https://github.com/NixOS/nixpkgs/pull/236006/checks?check_run_id=13997210471 |
CC maintainers @Br1ght0ne @numinit |
Looked at the NixOS tests, they should be fixed by #273273. |
Should we support this too (in another PR)? Bet this would have fixed the test flakiness too. |
@nh2 Test flakiness fix is merged. Once we merge this we'll do another PR for the systemd ready socket. |
cc @Jaculabilis (one of the original authors of the NixOS module) |
nebula: 1.7.2 -> 1.8.0
nebula: 1.7.2 -> 1.8.0
nebula: 1.7.2 -> 1.8.0
Description of changes
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.