-
-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
melpa: use newer package-build.el
to work around a breaking change in Emacs 30
#276401
Conversation
We can revert this once NixOS/nixpkgs#276401 is merged.
Are we still allowed to target |
Use staging until we have a less worse idea. (yes I am still disappointed on this...) |
package--prepare-dependencies has been renamed in a recent revision of Emacs 30.
bc583d5
to
8178cdf
Compare
@AndersonTorres OK, done. |
I have pushed an additional commit to avoid using patches entirely and instead use the latest upstream There have been multiple incompatible changes in upstream I tested briefly by building Emacs 30 with some packages across a couple of revisions of the overlay (including an overlay commit, temporarily reverted only because it requires a change similar to what is in this PR, containing the upstream Emacs change that motivated this PR). |
package-build.el
to work around a breaking change in Emacs 30
conflict and duplicate with #276943? |
package--prepare-dependencies has been renamed in a recent revision of
Emacs 30.
Description of changes
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.