-
-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update-melpa: try to fix some compatiblility issues on cl-lib and url-retrive. #277455
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reword the commit as update-melpa: use cl-lib instead of cl
deb6bd8
to
875a08f
Compare
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/3183 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides LGTM
875a08f
to
952b05c
Compare
This improves compatiblity of parsing http header.
952b05c
to
2e2097c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Waiting for mergers
Successfully created backport PR for |
The file changed by this PR is only used in the update script and does not cause any rebuild. So it is fine to to merge it into the master branch. |
This update script is employed to generate artifacts that should be merged on staging, not on master. On then other hand, no one is insane enough to generate artifacts directly on staging anyway. |
Description of changes
Tested
And the running result can be checked here
This commit try to fix it by some compatibility issues with the emacs update.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.