python3Packages.apted: init at 1.0.3 #277506
Merged
+33
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
8.has: package (new)
|
Result of 4 packages built:
|
wegank
added
the
2.status: stale
|
@ofborg build python312Packages.apted |
stale
bot
removed
the
2.status: stale
FliegendeWurst
previously requested changes
Nov 17, 2024
|
I think using diff --git a/pkgs/development/python-modules/apted/default.nix b/pkgs/development/python-modules/apted/default.nix
index 9a5a9eb979a7..617b02719872 100644
--- a/pkgs/development/python-modules/apted/default.nix
+++ b/pkgs/development/python-modules/apted/default.nix
@@ -3,12 +3,13 @@
buildPythonPackage,
fetchFromGitHub,
unittestCheckHook,
+ setuptools,
}:
-buildPythonPackage rec {
+buildPythonPackage {
pname = "apted";
version = "1.0.3";
- format = "setuptools";
+ pyproject = true;
src = fetchFromGitHub {
owner = "JoaoFelipe";
@@ -17,6 +18,10 @@ buildPythonPackage rec {
hash = "sha256-h8vJDC5TPpyhDxm1sHiXPegPB2eorEgyrNqzQOzSge8=";
};
+ build-system = [
+ setuptools
+ ];
+
nativeCheckInputs = [ unittestCheckHook ];
meta = with lib; { |
FliegendeWurst
approved these changes
Dec 29, 2024
natsukium
reviewed
Dec 30, 2024
|
|
||
| build-system = [ setuptools ]; | ||
| nativeCheckInputs = [ unittestCheckHook ]; | ||
|
|
There was a problem hiding this comment.
Could you please add pythonImportsCheck for a mock test?
Besides this LGTM.
There was a problem hiding this comment.
Thanks, I've added the import check.
Co-authored-by: Arne Keller <[email protected]>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
APTED is a Python library implementing the tree editing distance algorithm of the same name.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)