-
-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python312Packages.py65: 1.1.0 -> 1.2.0, clean up #279148
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomaSajt
force-pushed
the
py65
branch
2 times, most recently
from
March 22, 2024 23:01
88a1c32
to
4baba22
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
AndersonTorres
approved these changes
Mar 23, 2024
TomaSajt
changed the title
python311Packages.py65: clean up
python312Packages.py65: 1.1.0 -> 1.2.0, clean up
Apr 13, 2024
Result of 5 packages built:
|
Result of 5 packages built:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Changes:
pythonOlder
(I think this package even supports python2)pyproject = true;
to use the pypa builder (removes deprecation warnings)setuptools
tobuild-system
unittestCheckHook
tonativeBuildInputs
meta.changelog
meta.homepage
link, use the GitHub repo link insteadI am never sure how to order
meta
's attributes when there's ameta.longDescription
.Logically
description
andlongDescription
should be next to each other, but then I can't order the tags alphabetically, like I usually do...Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.