Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python312Packages.py65: 1.1.0 -> 1.2.0, clean up #279148

Merged
merged 1 commit into from
May 5, 2024
Merged

Conversation

TomaSajt
Copy link
Contributor

@TomaSajt TomaSajt commented Jan 6, 2024

Description of changes

Changes:

  • bump package version (last version was from 2018)
  • remove pythonOlder (I think this package even supports python2)
  • use pyproject = true; to use the pypa builder (removes deprecation warnings)
    • add setuptools to build-system
    • add unittestCheckHook to nativeBuildInputs
  • add meta.changelog
  • remove broken meta.homepage link, use the GitHub repo link instead

I am never sure how to order meta's attributes when there's a meta.longDescription.
Logically description and longDescription should be next to each other, but then I can't order the tags alphabetically, like I usually do...

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Jan 6, 2024
@TomaSajt TomaSajt force-pushed the py65 branch 2 times, most recently from 88a1c32 to 4baba22 Compare March 22, 2024 23:01
Copy link
Member

@AndersonTorres AndersonTorres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Mar 24, 2024
@TomaSajt TomaSajt changed the title python311Packages.py65: clean up python312Packages.py65: 1.1.0 -> 1.2.0, clean up Apr 13, 2024
@TomaSajt
Copy link
Contributor Author

Result of nixpkgs-review pr 279148 run on x86_64-linux 1

5 packages built:
  • py65 (python311Packages.py65)
  • py65.dist (python311Packages.py65.dist)
  • python312Packages.py65
  • python312Packages.py65.dist
  • smb3-foundry

@ofborg ofborg bot requested a review from AndersonTorres April 13, 2024 23:14
@wegank wegank removed the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Apr 22, 2024
@TomaSajt
Copy link
Contributor Author

TomaSajt commented May 2, 2024

Result of nixpkgs-review pr 279148 run on x86_64-linux 1

5 packages built:
  • py65 (python311Packages.py65)
  • py65.dist (python311Packages.py65.dist)
  • python312Packages.py65
  • python312Packages.py65.dist
  • smb3-foundry

@drupol drupol merged commit 093724d into NixOS:master May 5, 2024
27 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants