Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python311Packages.pyrfc3339: rename from pyRFC3339 #279346

Closed
wants to merge 1 commit into from

Conversation

Stunkymonkey
Copy link
Contributor

@Stunkymonkey Stunkymonkey commented Jan 7, 2024

Description of changes

part of #245383

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@Stunkymonkey
Copy link
Contributor Author

Result of nixpkgs-review pr 279346 run on x86_64-linux 1

2 packages failed to build:
  • simp_le
  • simp_le.dist
41 packages built:
  • certbot (python311Packages.certbot)
  • certbot-full
  • certbot.dist (python311Packages.certbot.dist)
  • python310Packages.acme
  • python310Packages.acme.dist
  • python310Packages.certbot
  • python310Packages.certbot-dns-cloudflare
  • python310Packages.certbot-dns-cloudflare.dist
  • python310Packages.certbot-dns-google
  • python310Packages.certbot-dns-google.dist
  • python310Packages.certbot-dns-inwx
  • python310Packages.certbot-dns-inwx.dist
  • python310Packages.certbot-dns-ovh
  • python310Packages.certbot-dns-ovh.dist
  • python310Packages.certbot-dns-rfc2136
  • python310Packages.certbot-dns-rfc2136.dist
  • python310Packages.certbot-dns-route53
  • python310Packages.certbot-dns-route53.dist
  • python310Packages.certbot.dist
  • python310Packages.hass-nabucasa
  • python310Packages.hass-nabucasa.dist
  • python310Packages.pyrfc3339
  • python310Packages.pyrfc3339.dist
  • python311Packages.acme
  • python311Packages.acme.dist
  • python311Packages.certbot-dns-cloudflare
  • python311Packages.certbot-dns-cloudflare.dist
  • python311Packages.certbot-dns-google
  • python311Packages.certbot-dns-google.dist
  • python311Packages.certbot-dns-inwx
  • python311Packages.certbot-dns-inwx.dist
  • python311Packages.certbot-dns-ovh
  • python311Packages.certbot-dns-ovh.dist
  • python311Packages.certbot-dns-rfc2136
  • python311Packages.certbot-dns-rfc2136.dist
  • python311Packages.certbot-dns-route53
  • python311Packages.certbot-dns-route53.dist
  • python311Packages.hass-nabucasa
  • python311Packages.hass-nabucasa.dist
  • python311Packages.pyrfc3339
  • python311Packages.pyrfc3339.dist

@Stunkymonkey Stunkymonkey marked this pull request as ready for review January 7, 2024 12:15
@AndersonTorres
Copy link
Member

Please send this to staging branch.

#276943 (comment)

Furthermore, if the change causes a mass rebuild, use the appropriate staging branch instead
As a rule of thumb, if the number of rebuilds is over 500, it can be considered a mass rebuild.

@Stunkymonkey Stunkymonkey requested a review from a user January 7, 2024 12:50
@Stunkymonkey Stunkymonkey changed the base branch from master to staging January 7, 2024 12:50
@ajs124 ajs124 closed this Jan 7, 2024
@Stunkymonkey Stunkymonkey deleted the pyrfc3339-normalize branch January 7, 2024 22:27
@Stunkymonkey Stunkymonkey restored the pyrfc3339-normalize branch January 7, 2024 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants