Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clairvoyant: 3.1.2 -> 3.1.3 #285227

Merged
merged 3 commits into from
Apr 13, 2024
Merged

clairvoyant: 3.1.2 -> 3.1.3 #285227

merged 3 commits into from
Apr 13, 2024

Conversation

michaelgrahamevans
Copy link
Contributor

Description of changes

Supersedes #285165 and adds:

  • wrapGAppsHook4 to fix the app's icon not showing in the about window
  • switch to the finalAttrs pattern
  • an option to disable the "Unsupported version of this app" banner shown when not running as a Flatpak (disabled by default as I feel this is a valid and useful notice)

Upstream changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

r-ryantm and others added 3 commits January 31, 2024 03:38
@r-ryantm
clairvoyant: 3.1.2 -> 3.1.3
543c6ce
@michaelgrahamevans
clairvoyant: Add wrapGAppsHook4 and use finalAttrs pattern
e0905a8
@michaelgrahamevans
clairvoyant: Add hideUnsupportedVersionBanner option
4beb689 
Clairvoyant v3.1.3 introduced a non-dismissble banner stating that this
version of the app is unsupported, which is shown when the app detects
that it is not running as a Flatpak. This change adds the
"hideUnsupportedVersionBanner" option, disabled by default, which makes
it look like the app is running as a Flatpak.
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Jan 31, 2024
@pbsds pbsds merged commit 311da28 into NixOS:master Apr 13, 2024
27 checks passed
@michaelgrahamevans michaelgrahamevans deleted the clairvoyant-3.1.3 branch April 18, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michaelgrahamevans @pbsds @r-ryantm