luarocks: 3.9.1 -> 3.9.2 #288130
luarocks: 3.9.1 -> 3.9.2 #288130
Conversation
|
as per pkgs/by-name check
this is probably due to this in all-packages.nix maybe @infinisil can suggest a solution ? |
I believe it will require way more advanced features not yet present on the current by-name structure. |
|
if that's the case, then we should move files back |
|
The error should be improved, but indeed |
|
Okay, in that case I'll move the luarocks package back where it was before |
|
|
||
| src = fetchFromGitHub { | ||
| owner = "luarocks"; | ||
| repo = "luarocks"; | ||
| rev = "v${finalAttrs.version}"; | ||
| sha256 = "sha256-G6HDap3pspeQtGDBq+ukN7kftDaT/CozMVdYM60F6HI="; | ||
| hash = "sha256-D5jH7QuPayDNskIhiPeqKzI9m33MjRjQ8ReghFIUlPo="; | ||
| }; | ||
|
|
||
| patches = [ | ||
| ./darwin-3.7.0.patch |
There was a problem hiding this comment.
What does this patch do?
delroth
added
12.approvals: 2
Description of changes
Changes: https://github.com/luarocks/luarocks/blob/master/CHANGELOG.md#whats-new-in-luarocks-392
Diff: luarocks/luarocks@v3.9.1...v3.9.2
Also migrated to pkgs/by-name.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.