-
-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport master] tree-sitter: 0.20.8 -> 0.20.9 #288314
Conversation
Self-merging a huge rebuild directly to the master branch? |
What was the basis for this decision for merging directly to master? No explanation, no reference. |
I think the decision referred to was here. |
Current nixpkgs master contains everything that was on |
So far I'm inclined to say it's basically the same as Emacs packages, even with a large overlap in the rebuilt package sets at a quick glance: |
I don't think you understood. neovim-nightly does not build without this tree-sitter version. |
I decided to send it to master after discussing with a couple of other nixpkgs comitters/maintainers/contributors in the Matrix channel about it. They said that if since these PRs were usually sent to master (previous tree-sitter updates) and that almost all of the rebuilds are just text editor plugins then it should be fine. I can defer though. |
Big tree-sitter rebuilds merged to master recently? I failed to find them quickly, but maybe I searched wrong |
For example: #225148 |
That was in my listing. But that was a year ago which doesn't match my "recently". I let it pass. But I'd really dislike such merges to become common, at least unless we have evidence that they really are cheap for the infra (I don't think they are). |
Description of changes
This is a backport of #284045 to master.
I accidentally sent it to staging instead of master after deciding with other contributors/maintainers that it should actually go straight to master.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.