vale-ls: init at 0.3.7 #288450
vale-ls: init at 0.3.7 #288450
Conversation
ofborg
bot
added
8.has: package (new)
| ]; | ||
|
|
||
| cargoHash = "sha256-QEU9e8KTAnLD9ykV+C87iVKojX2aEDRwocwvZcxpOU8="; | ||
| cargoPatches = [ ./0001-Update-dependencies.patch ]; |
There was a problem hiding this comment.
As of a couple of days ago, upstream publishes a lockfile. Can we take that patch instead, to keep us at parity with upstream?
| ]; | ||
|
|
||
| cargoHash = "sha256-QEU9e8KTAnLD9ykV+C87iVKojX2aEDRwocwvZcxpOU8="; | ||
| cargoPatches = [ ./0001-Update-dependencies.patch ]; |
There was a problem hiding this comment.
Instead of patching Cargo.toml to remove the vendored feature flag from openssl, can we set the OPENSSL_NO_VENDOR environment variable at build time? Seems easier than maintaining a patch and regenerating the lockfile every time there's a release.
From the relevant documentation:
OPENSSL_NO_VENDOR- If set, always find OpenSSL in the system, even if the vendored feature is enabled.
There was a problem hiding this comment.
By default, vale-ls downloads a copy of vale to use. I don't think that's desirable, since we already package vale in nixpkgs.
I think it would be best to wrap the executable to (a) set the initialization parameter installVale to false and (b) add nixpkgs' copy of vale to PATH.
Relevant documentation:
https://vale.sh/docs/integrations/guide/#vale-ls
|
|
||
| src = fetchFromGitHub { | ||
| owner = "errata-ai"; | ||
| repo = pname; |
There was a problem hiding this comment.
Nit: Setting repo = pname considered harmful by some. (#277994)
|
The The test can be skipped on that architecture, since it relates to the "download |
wegank
added
the
2.status: merge conflict
|
(this is included in #304375 which is now merged) |
Description of changes
Add LSP server for Vale.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.