glog: 0.6.0 -> 0.7.1 #289608

r-ryantm · 2024-02-17T20:39:46Z

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/google/glog/releases.

meta.description for glog is: Library for application-level logging

meta.homepage for glog is: https://github.com/google/glog

Updates performed

Version update

To inspect upstream changes

Impact

Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 0.7.0 with grep in /nix/store/msbn00ykbswj5ri1q0avh8g5pdsv4z2n-glog-0.7.0
found 0.7.0 in filename of file in /nix/store/msbn00ykbswj5ri1q0avh8g5pdsv4z2n-glog-0.7.0

Rebuild report (if merged into master) (click to expand)

2182 total rebuild path(s)

2182 package rebuild(s)

First fifty rebuilds by attrpath
ansible-doctor
apacheHttpdPackages.mod_tile
apacheHttpdPackages_2_4.mod_tile
arrow-cpp
arrow-glib
asn1editor
authentik
barman
beancount
breezy
brise
browsr
buck
buildbot
buildbot-full
buildbot-ui
cabal2nix
caffe
caffeWithCuda
calcurse
cantor
ceph
ceph-client
ceph-csi
ceph-dev
ceres-solver
certbot-full
cfripper
chatgpt-retrieval-plugin
cloudcompare
coconut
colmap
colmapWithCuda
conan
crackmapexec
csvkit
databricks-sql-cli
datalad
dbx
deface
deja-dup
dep2nix
devpi-client
dnstwist
dragonflydb
duplicity
duply
dvc
dvc-with-remotes
dwarfs

Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/msbn00ykbswj5ri1q0avh8g5pdsv4z2n-glog-0.7.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A glog https://github.com/r-ryantm/nixpkgs/archive/d851940e3c16fc1dde937e3608ef6eb10d4dbfe0.tar.gz

Or:

nix build github:r-ryantm/nixpkgs/d851940e3c16fc1dde937e3608ef6eb10d4dbfe0#glog

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/msbn00ykbswj5ri1q0avh8g5pdsv4z2n-glog-0.7.0
ls -la /nix/store/msbn00ykbswj5ri1q0avh8g5pdsv4z2n-glog-0.7.0/bin

Pre-merge build results

NixPkgs review skipped

Maintainer pings

cc @nh2 @r-burns for testing.

marsam · 2024-03-28T12:38:31Z

@GrahamcOfBorg eval

r-ryantm · 2024-06-13T19:00:19Z

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/google/glog/releases.

meta.description for glog is: Library for application-level logging

meta.homepage for glog is: https://github.com/google/glog

Updates performed

Version update

To inspect upstream changes

Impact

Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 0.7.1 with grep in /nix/store/qlkrndcx0w5j2szzrvmp2rcc3map37x3-glog-0.7.1
found 0.7.1 in filename of file in /nix/store/qlkrndcx0w5j2szzrvmp2rcc3map37x3-glog-0.7.1

Rebuild report (if merged into master) (click to expand)

3334 total rebuild path(s)

3334 package rebuild(s)

First fifty rebuilds by attrpath

anki
ansible-doctor
apacheHttpdPackages.mod_tile
apacheHttpdPackages_2_4.mod_tile
arrow-cpp
arrow-glib
asn1editor
authentik
backgroundremover
barman
beancount
breezy
brise
browsr
buck
buildbot
buildbot-full
buildbot-ui
buildbotPackages.buildbot
buildbotPackages.buildbot-full
buildbotPackages.buildbot-ui
cabal2nix
caffe
caffeWithCuda
calcurse
cantor
ceph
ceph-client
ceph-csi
ceph-dev
ceres-solver
certbot-full
cfripper
chatgpt-retrieval-plugin
cloudcompare
coconut
colmap
colmapWithCuda
conan
crackmapexec
databricks-sql-cli
datalad
datatrove
dbx
deface
deja-dup
dep2nix
devpi-client
dnstwist

Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/qlkrndcx0w5j2szzrvmp2rcc3map37x3-glog-0.7.1 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A glog https://github.com/r-ryantm/nixpkgs/archive/8f4ecc04ffefa41e9b10ca6699431101d5894212.tar.gz

Or:

nix build github:r-ryantm/nixpkgs/8f4ecc04ffefa41e9b10ca6699431101d5894212#glog

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/qlkrndcx0w5j2szzrvmp2rcc3map37x3-glog-0.7.1
ls -la /nix/store/qlkrndcx0w5j2szzrvmp2rcc3map37x3-glog-0.7.1/bin

Pre-merge build results

NixPkgs review skipped

Maintainer pings

cc @nh2 @r-burns for testing.

nh2 · 2024-06-23T14:54:48Z

I started building the direct dependents of glog using:

nix-build --no-out-link $(nix-store -q --referrers $(nix-instantiate -A glog)) --keep-going

Failures:

`folly-2024.03.11.00`

In file included from /build/source/folly/CancellationToken-inl.h:23,
                 from /build/source/folly/CancellationToken.h:365,
                 from /build/source/folly/CancellationToken.cpp:17:
/nix/store/9y0cswrb58vw8vshmi14mrs4v9lqs25c-glog-0.7.1/include/glog/logging.h:60:4: error: #error <glog/logging.h> was not included correctly. See the documentation for how to consume the library.
   60 | #  error <glog/logging.h> was not included correctly. See the documentation for how to consume the library.
      |    ^~~~~

Looks like:

Support glog 0.7.0 facebook/folly#2171

I commented there that AUR has a patch, applying that here fixes that.

It further needed this patch I made:

symbolizer: Fix missing unistd.h include. facebook/folly#2245

I pushed 2 patches into this PR that fixes those. I hope that works with r-ryantm's workflows.

Other failed packages

caffe-1.0
dwarfs-0.9.9
gnss-sdr-0.0.19.1
lomiri-download-manager-0.1.3
mir-2.15.0
natron-2.5.0
python3.11-opensfm-unstable-2023-12-09
python3.12-opensfm-unstable-2023-12-09
trust-store-2.0.2

Many of them have similar error messages as folly had.

See also:

glog 0.7 breaks arrow, GLOG_USE_GLOG_EXPORT not working as intended? conda-forge/glog-feedstock#26 (comment)
dwarfs vendors folly as a git submodule (used in nixpkgs) and fails despite an apparent upstream fix:
- fails to build with google-glog 0.7.0 mhx/dwarfs#201 (comment)
- This is because nixpkgs accidentally packages an old version under a new version number:
  - dwarfs: 0.7.5 → 0.9.9 #312656 (comment)
    PR I made to fix that:
    - dwarfs: 0.7.5 → 0.9.10 #321996

nh2 · 2024-06-23T18:12:16Z

Running out of time; somebody else would have to take a look at the remaining build failures, please.

superherointj · 2024-10-16T09:22:05Z

@nh2 My take on builds:

Taking as reference staging-next (I rebased this PR on it) because it's latest and I have cache for it:

Builds OK:

arrow-cpp
ceres-solver
dwarfs
mir

Builds with fix:

caffe:

  # File: pkgs/applications/science/math/caffe/default.nix
postPatch = ''
  substituteInPlace CMakeLists.txt \
    --replace-fail "# ---[ Flags" \
                   "# ---[ Flags
    add_compile_definitions(GLOG_USE_GLOG_EXPORT)"
  '';

trust-store (lomiri.trust-store):

# File: pkgs/desktops/lomiri/development/trust-store/default.nix
postPatch = ''
  sed -i '17i add_compile_definitions(GLOG_USE_GLOG_EXPORT)' CMakeLists.txt
'';

python3Packages.opensfm

Error:

error <glog/logging.h> was not included correctly.
staging-next logs: https://termbin.com/y0uz

Fix:

# File: pkgs/development/python-modules/opensfm/default.nix
postPatch = ''
  sed -i '47i add_compile_definitions(GLOG_USE_GLOG_EXPORT)' opensfm/src/CMakeLists.txt
'';

Errors on master:

python3Packages.opensfm
- master error logs: https://termbin.com/5kyp
  
  ModuleNotFoundError: No module named 'distutils'
gnss-sdr (depends on python3Packages.pyqt6)
- master error logs: https://termbin.com/ihop
- staging-next error logs: https://termbin.com/rf1y
  
  error: 'LogMessageVoidify' is not a member of 'google'
natron
- master error logs: https://termbin.com/xi4c
- staging-next error logs: https://termbin.com/b0mk

Blockers for this PR:

Apply caffe, trust-store fix.

nh2 · 2024-10-16T13:55:57Z

@superherointj Good finds for the fixes.

The sed -i 52i with offsets will not be very reliable if upstream changes.

Would it be possible to rewrite them with substituteInPlace with --replace-fail, so we can get a good error when upstream diverges so the patch no longer applies?

Thank you!

superherointj · 2024-10-16T15:16:26Z

The sed -i 52i with offsets will not be very reliable if upstream changes.

Would it be possible to rewrite them with substituteInPlace with --replace-fail, so we can get a good error when upstream diverges so the patch no longer applies?

caffe:
trust-store:
python3Packages.opensfm

FYI I don't have permission for pushing code to this PR and I can only suggest code here through human communication. I could open a new PR, but then, is it desirable? Likely not.

Alternatively, cherry-pick is available from:

https://github.com/superherointj/nixpkgs/tree/auto-update/glog

Feel free to proceed as you wish.

superherointj · 2024-10-16T18:59:31Z

Would be nice to have enabled:

outputs = [ "dev" "out" ]; # Saves on closure size

strictDeps = true; # Aids in cross compiling

nh2 · 2024-10-17T00:47:42Z

I could open a new PR, but then, is it desirable?

@superherointj That's totally fine, you can create a new PR, especially when iterating on @r-ryantm's PRs (who is a bot).

We can then close this PR in favour of yours.

ofborg bot requested review from nh2 and r-burns February 17, 2024 22:55

ofborg bot added 10.rebuild-darwin: 101-500 10.rebuild-linux: 501+ 10.rebuild-linux: 2501-5000 labels Feb 17, 2024

wegank marked this pull request as draft April 5, 2024 18:35

glog: 0.6.0 -> 0.7.1

8f4ecc0

r-ryantm changed the title ~~glog: 0.6.0 -> 0.7.0~~ glog: 0.6.0 -> 0.7.1 Jun 13, 2024

r-ryantm force-pushed the auto-update/glog branch from e12c625 to 8f4ecc0 Compare June 13, 2024 19:00

nh2 added 2 commits June 23, 2024 14:53

glog: Enable pkg-config files

bd59d35

folly: Fix build with glog >= 0.7.0

98961be

ofborg bot requested review from pierreis and abbradar June 23, 2024 15:25

superherointj mentioned this pull request Oct 17, 2024

[WIP] glog: 0.6.0 -> 0.7.1 #349183

Closed

wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Nov 9, 2024

Aleksanaa closed this Dec 8, 2024

r-ryantm deleted the auto-update/glog branch December 9, 2024 00:26

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

glog: 0.6.0 -> 0.7.1 #289608

glog: 0.6.0 -> 0.7.1 #289608

r-ryantm commented Feb 17, 2024

marsam commented Mar 28, 2024

r-ryantm commented Jun 13, 2024

nh2 commented Jun 23, 2024 •

edited

Loading

nh2 commented Jun 23, 2024

superherointj commented Oct 16, 2024 •

edited

Loading

nh2 commented Oct 16, 2024

superherointj commented Oct 16, 2024 •

edited

Loading

superherointj commented Oct 16, 2024

nh2 commented Oct 17, 2024

glog: 0.6.0 -> 0.7.1 #289608

glog: 0.6.0 -> 0.7.1 #289608

Conversation

r-ryantm commented Feb 17, 2024

Updates performed

To inspect upstream changes

Impact

Pre-merge build results

Maintainer pings

marsam commented Mar 28, 2024

r-ryantm commented Jun 13, 2024

Updates performed

To inspect upstream changes

Impact

Pre-merge build results

Maintainer pings

nh2 commented Jun 23, 2024 • edited Loading

folly-2024.03.11.00

Other failed packages

nh2 commented Jun 23, 2024

superherointj commented Oct 16, 2024 • edited Loading

nh2 commented Oct 16, 2024

superherointj commented Oct 16, 2024 • edited Loading

superherointj commented Oct 16, 2024

nh2 commented Oct 17, 2024

nh2 commented Jun 23, 2024 •

edited

Loading

`folly-2024.03.11.00`

superherointj commented Oct 16, 2024 •

edited

Loading

superherointj commented Oct 16, 2024 •

edited

Loading