Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

opengfw: init at 0.4.0 (+NixOS module) #290008

Merged
merged 3 commits into from
Jul 24, 2024
Merged

opengfw: init at 0.4.0 (+NixOS module) #290008

merged 3 commits into from
Jul 24, 2024

Conversation

eum3l
Copy link
Contributor

@eum3l eum3l commented Feb 19, 2024 •
edited
Loading

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: documentation 8.has: changelog 8.has: module (update) This PR changes an existing module in `nixos/` labels Feb 19, 2024
@eum3l eum3l changed the title opengfw: init at 0.2.0; nixos/opengfw: init opengfw: init at 0.2.0 (+nix module) Feb 19, 2024
@NixOSInfra NixOSInfra added the 12. first-time contribution This PR is the author's first one; please be gentle! label Feb 19, 2024
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Feb 19, 2024
@eum3l eum3l force-pushed the add-opengfw branch 3 times, most recently from 9d16c94 to cb0e29f Compare February 24, 2024 16:24
@eum3l eum3l mentioned this pull request Feb 24, 2024
Closed
@eum3l eum3l force-pushed the add-opengfw branch 2 times, most recently from 8e894b6 to 82ab699 Compare March 1, 2024 20:12
@ifurther
Copy link
Contributor

Please update the title, and squash comment

@eum3l eum3l changed the title opengfw: init at 0.2.0 (+nix module) opengfw: init at 0.2.3 (+NixOS module) Mar 16, 2024
@eum3l eum3l force-pushed the add-opengfw branch 3 times, most recently from a2a7154 to a7a00c4 Compare March 22, 2024 12:38
@eum3l eum3l changed the title opengfw: init at 0.2.3 (+NixOS module) opengfw: init at 0.3.0 (+NixOS module) Mar 22, 2024
@ifurther
Copy link
Contributor

Please split the maintainers and application comment

@eum3l eum3l changed the title opengfw: init at 0.3.0 (+NixOS module) opengfw: init at 0.3.1 (+NixOS module) Apr 2, 2024
@eum3l eum3l force-pushed the add-opengfw branch 3 times, most recently from 1792ae7 to c99b4d5 Compare April 3, 2024 14:52
@eum3l eum3l force-pushed the add-opengfw branch 2 times, most recently from b73c238 to d0a4346 Compare May 12, 2024 13:20
@ofborg ofborg bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label May 12, 2024
@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label May 12, 2024
@h7x4 h7x4 added the 8.has: module (new) This PR adds a module in `nixos/` label Jun 1, 2024
@eum3l eum3l force-pushed the add-opengfw branch 2 times, most recently from 19f44a7 to 93dd63a Compare June 5, 2024 12:31
@eum3l eum3l force-pushed the add-opengfw branch 2 times, most recently from 00a8901 to 7d1148b Compare June 13, 2024 09:17
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/4116

0x61nas
0x61nas suggested changes Jun 21, 2024
View reviewed changes
pkgs/by-name/op/opengfw/package.nix Show resolved Hide resolved
pkgs/by-name/op/opengfw/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/op/opengfw/package.nix Outdated Show resolved Hide resolved
@0x61nas 0x61nas self-requested a review June 25, 2024 08:14
@eum3l eum3l force-pushed the add-opengfw branch 2 times, most recently from 5b5162e to b908938 Compare July 1, 2024 10:05
@JohnRTitor
Copy link
Contributor

Result of nixpkgs-review pr 290008 run on x86_64-linux 1

1 package blacklisted:
  • nixos-install-tools
1 package built:
  • opengfw

JohnRTitor
JohnRTitor approved these changes Jul 11, 2024
View reviewed changes
Copy link
Contributor

@JohnRTitor JohnRTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Built NixOS manual looks good. @Aleksanaa do you want to take a look?

@JohnRTitor JohnRTitor merged commit 81cb83b into NixOS:master Jul 24, 2024
26 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@div72 div72 div72 left review comments

@JohnRTitor JohnRTitor JohnRTitor approved these changes

@Aleksanaa Aleksanaa Aleksanaa left review comments

@0x61nas 0x61nas Awaiting requested review from 0x61nas

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog 8.has: documentation 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 8.has: module (new) This PR adds a module in `nixos/` 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@eum3l @ifurther @nixos-discourse @JohnRTitor @Aleksanaa @0x61nas @div72 @wegank @h7x4 @NixOSInfra