-
-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add protoc-go-inject-tag to nixpkgs #292481
Conversation
all the files look good, one last step, you need to squash the last two commits together so you have:
i believe |
Nice! I don't have my PC with me right now, I'll do it later |
Done! |
It builds on M1 too! |
@ElrohirGT are you able to clear the merge conflicts? PR looks good otherwise |
Sure! I'll clean them up this afternoon. It should still only contain two commits right? The one that adds me as maintainer and the one that adds the package. |
Yes, should still be only two - you should be able to replay the commits over the current master and then fix the conflict in the maintainers file - rebase and squash as before if needed |
Sorry! I think I messed up a little and closed this PR on accident while updating my fork. I don't really know how that happened probably by force pushing. Anyways, here's the fixed PR. |
Description of changes
This is a new package used for go-tags and protobuffers: Homepage
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.