Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hyprland-workspaces: init at 2.0.0 #296202

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

donovanglover
Copy link
Member

Description of changes

Closes #295965

Formatted with nixfmt-rfc-style

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@kiike
Copy link
Member

kiike commented Apr 19, 2024

Hi @donovanglover! I just noticed this PR just right after I submitted mine for version 2 of this program. Would you update yours and then I'll close mine? Or if you prefer, we can keep mine. Whatever you wish!

@donovanglover donovanglover changed the title hyprland-workspaces: init at 1.2.5 hyprland-workspaces: init at 2.0.0 Apr 20, 2024
@donovanglover
Copy link
Member Author

Fixed thanks

@Aleksanaa
Copy link
Member

@kiike would you like to co-maintain this package?

@kiike
Copy link
Member

kiike commented Apr 20, 2024

Thanks for the change! I'll test the output and post a comment. I guess it just works. I have a PR for a companion program to hyprland too at #305404. Would you like take a look at it?

@kiike
Copy link
Member

kiike commented Apr 20, 2024

@kiike would you like to co-maintain this package?

Sure 😄 ! I use the program all day anyway!

Copy link
Member

@kiike kiike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Tried the resulting binary and it works perfectly. 🙇

@Aleksanaa Aleksanaa merged commit 4da334c into NixOS:master Apr 24, 2024
26 checks passed
@donovanglover donovanglover deleted the hyprland-workspaces branch August 2, 2024 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Package request: hyprland-workspaces
3 participants