-
-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hyprland-workspaces: init at 2.0.0 #296202
Conversation
Hi @donovanglover! I just noticed this PR just right after I submitted mine for version 2 of this program. Would you update yours and then I'll close mine? Or if you prefer, we can keep mine. Whatever you wish! |
d262268
to
6ff302d
Compare
Fixed thanks |
@kiike would you like to co-maintain this package? |
Thanks for the change! I'll test the output and post a comment. I guess it just works. I have a PR for a companion program to hyprland too at #305404. Would you like take a look at it? |
Sure 😄 ! I use the program all day anyway! |
6ff302d
to
cd5f77b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Tried the resulting binary and it works perfectly. 🙇
Description of changes
Closes #295965
Formatted with nixfmt-rfc-style
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.