Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

st: 0.9 -> 0.9.1 #297472

Merged
merged 2 commits into from
Apr 1, 2024
Merged

st: 0.9 -> 0.9.1 #297472

merged 2 commits into from
Apr 1, 2024

Conversation

Qusic
Copy link
Member

@Qusic Qusic commented Mar 20, 2024

Description of changes

Changelog

Result of nixpkgs-review run on x86_64-linux 1

2 packages built:
  • st
  • st.terminfo

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@AndersonTorres
Copy link
Member

@andsild looks like not maintaining this

#290642
https://github.com/andsild/nixpkgs

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/3705

@AndersonTorres
Copy link
Member

Are you interested in being the new maintainer, @Qusic?
If so, then change the maintainer.

@Qusic
Copy link
Member Author

Qusic commented Mar 28, 2024

@AndersonTorres sure. i am now waiting for merging #298801 which is already approved and adds me to maintainer-list. then I will add myself to this package.

@SuperSandro2000
Copy link
Member

other PR got merged

@Qusic
Copy link
Member Author

Qusic commented Apr 1, 2024

Thanks! Also I split updateScript into another PR and please help review both at your convenience. #298793

@ofborg ofborg bot added the 11.by: package-maintainer This PR was created by the maintainer of the package it changes label Apr 1, 2024
@SuperSandro2000 SuperSandro2000 merged commit 9078780 into NixOS:master Apr 1, 2024
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants