Fix slither-analyzer by upgrading its python dependencies | slither-analyzer: 0.10.1 -> 0.10.2 #298687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ofborg build slither-analyzer again |
|
As of now: Result of 5 packages marked as broken and skipped:
14 packages failed to build:
70 packages built:
Checking if there were any regressions... |
|
A quick check from the master branch suggests that those are not regressions. So, I am making this ready for review now. |
dotlambda
reviewed
Mar 24, 2024
dotlambda
reviewed
Mar 24, 2024
|
|
||
| pythonImportsCheck = [ |
There was a problem hiding this comment.
okay. let me add it back.
ofborg
bot
added
11.by: package-maintainer
hellwolf
force-pushed
the
update-python-eth-rlp-packages
branch
from
ace661b
to
7afd3d9
Compare
dotlambda
reviewed
Mar 24, 2024
Comment on lines
26
to
27
| nativeBuildInputs = [ | ||
| setuptools-scm |
There was a problem hiding this comment.
Suggested change
| nativeBuildInputs = [ | |
| setuptools-scm | |
| build-system = [ | |
| setuptools |
and elsewhere
There was a problem hiding this comment.
what's the difference between setuptools and setuptools-scm, I saw somewhere else was setuptools-scm.
There was a problem hiding this comment.
SCM sets the version from a git tag. Upstream decides what they use.
There was a problem hiding this comment.
thanks. I changed them all.
dotlambda
reviewed
Mar 24, 2024
hellwolf
force-pushed
the
update-python-eth-rlp-packages
branch
3 times, most recently
from
be9b33e
to
89327b7
Compare
Hmm, I don't know what to do exactly. I didn't intend to be the packager of these packages. Would you be okay merge them now, since they should be strictly not worse than before? Or: suggest the changes, I can do rebasings. |
hellwolf
force-pushed
the
update-python-eth-rlp-packages
branch
from
89327b7
to
adde7b8
Compare
|
@dotlambda what's left to do for this one before we can merge? |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/3699 |
hellwolf
force-pushed
the
update-python-eth-rlp-packages
branch
2 times, most recently
from
fc9243c
to
902522b
Compare
hellwolf
changed the title
|
@ofborg build slither-analyzer |
- use pyproject & setuptools-scm - remove the setuptools-markdown post patch
- use pyproject & setuptools-scm
- use pyproject & setuptools-scm
- use pyproject & setuptools-scm
- use pyproject & setuptools-scm - remove the setuptools-markdown post patch
- use setuptools-scm
hellwolf
force-pushed
the
update-python-eth-rlp-packages
branch
from
902522b
to
95eca14
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This fixes #294418 (broken slither binary.)
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.