Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parquet-tools: support Moto 5.x #301220

Merged
merged 1 commit into from
Apr 3, 2024
Merged

Conversation

edef1c
Copy link
Member

@edef1c edef1c commented Apr 3, 2024

Description of changes

This makes the test fixtures compatible with the new Moto API.

Supersedes #301032

Upstream issue: ktrueda/parquet-tools#54
Upstream PR: ktrueda/parquet-tools#55

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

This makes the test fixtures compatible with the new Moto API.

Close NixOS#301032

Link: ktrueda/parquet-tools#54
Link: ktrueda/parquet-tools#55
@flokli flokli merged commit 33fcd9c into NixOS:master Apr 3, 2024
12 of 13 checks passed
@flokli
Copy link
Contributor

flokli commented Apr 3, 2024

Nice, thanks! Agreed on shipping the patch in here, in case changes to ktrueda/parquet-tools#55 are requested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants